Skip to content

SF stability check: wait while a recreated app is not yet deployed on its node - #25

Merged
Germandf merged 1 commit into
mainfrom
fix/sf-stability-app-not-yet-deployed
Nov 16, 2026
Merged

Germandf merged 1 commit into
mainfrom
fix/sf-stability-app-not-yet-deployed

Conversation

@Germandf

@Germandf Germandf commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Problema: tras recrear la app, Get-ServiceFabricDeployedCodePackage responde 'Application not found' en un nodo que ya tiene réplica y el chequeo abortaba (falso positivo; Payroll run 43927657408, app Ready/Ok).
Cambio: ese caso devuelve un snapshot NotDeployed y el chequeo sigue esperando hasta ReadyTimeoutSeconds; cualquier otro error sigue abortando y un reinicio o Health no Ok en la ventana sigue fallando.
Probado: Test-ServiceFabricStability.ps1 local (casos nuevos incluidos). Runners: el workflow no cambia, sigue self-hosted.

🤖 Generated with Claude Code

CI: repo público sin runner propio que lo acepte (decision-fixtures queda en cola). Igual que en #24, se corrió localmente pwsh -File .github/actions/verify-servicefabric-stable/tests/Test-ServiceFabricStability.ps1: todos los casos PASS, incluidos los 4 nuevos.

…in the stability check

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T19:26:53.108634Z f89d846 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f89d84604a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +72 to +73
if ($notDeployedOn.Count -gt 0) {
$state = 'NotDeployed'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve Error health when a node has not deployed the application

If application health is Error while a node returns FabricElementNotFoundException, this assignment replaces the actual health with NotDeployed. If that condition persists until the readiness timeout, Wait-SfApplicationStable returns NeverOk with Health = 'NotDeployed', so Test-SfRollbackWarranted returns false and a configured rollback is skipped despite the application's Error health. Preserve Error when marking incomplete deployment, or track deployment readiness separately so it does not suppress the rollback decision.

Useful? React with 👍 / 👎.

@Germandf
Germandf merged commit 3c7e9d9 into main Nov 16, 2026
1 check failed
@Germandf
Germandf deleted the fix/sf-stability-app-not-yet-deployed branch November 16, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant